-
Notifications
You must be signed in to change notification settings - Fork 41
Fix oh
for model: EC-Earth3-AerChem mip: AERMonZ
#2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
=======================================
Coverage 94.96% 94.97%
=======================================
Files 253 253
Lines 14706 14714 +8
=======================================
+ Hits 13966 13974 +8
Misses 740 740 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Bouwe Andela <[email protected]>
oh
for EC-Earth3 AERMonZoh
for model: EC-Earth3-AerChem mip: AERMonZ
NB Mme Michou's recipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny comment on the docstring, apart from that it looks good! Cheers 🚀
Co-authored-by: Manuel Schlund <[email protected]>
thanks a lot, gents! 🍻 |
Description
Closes #2613
Link to documentation: no need
We discussed this issue at large in #2613 and the solution proposed by Manu @schlunma is implemented here, ie set the ps' standard_name (variable at issue is oh: "mole_fraction_of_hydroxyl_radical_in_air" in AERmonZ) to
surface_air_pressure
to avoid two coordinated with the same standard nameair_pressure
.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: