Skip to content

Fix oh for model: EC-Earth3-AerChem mip: AERMonZ #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 16, 2025
Merged

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 16, 2025

Description

Closes #2613

Link to documentation: no need

We discussed this issue at large in #2613 and the solution proposed by Manu @schlunma is implemented here, ie set the ps' standard_name (variable at issue is oh: "mole_fraction_of_hydroxyl_radical_in_air" in AERmonZ) to surface_air_pressure to avoid two coordinated with the same standard name air_pressure.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the fix for dataset Related to dataset-specific fix files label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (542a374) to head (ea8c87b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2634   +/-   ##
=======================================
  Coverage   94.96%   94.97%           
=======================================
  Files         253      253           
  Lines       14706    14714    +8     
=======================================
+ Hits        13966    13974    +8     
  Misses        740      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi changed the title Fix oh for EC-Earth3 AERMonZ Fix oh for model: EC-Earth3-AerChem mip: AERMonZ Jan 16, 2025
@valeriupredoi
Copy link
Contributor Author

NB Mme Michou's recipe
now runs fine 😃

@schlunma schlunma added this to the v2.12.0 milestone Jan 16, 2025
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment on the docstring, apart from that it looks good! Cheers 🚀

@valeriupredoi
Copy link
Contributor Author

thanks a lot, gents! 🍻

@valeriupredoi valeriupredoi merged commit f86d151 into main Jan 16, 2025
6 checks passed
@valeriupredoi valeriupredoi deleted the fix_oh_AerMon branch January 16, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset problem: Automatic fixing for errors in AERmon cmor data?
3 participants