Skip to content

Set a temporary pin dask <2025.4.0 while Iris are looking for a solution #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 6, 2025

Description

The issue is described in #2716 - so far there is no solution from Iris, and while we are waiting, we ought to have our tests pass. I will get back to Iris folks see if I can help with isolating the problem (through Dask).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi requested a review from bouweandela May 6, 2025 12:57
@valeriupredoi valeriupredoi added the installation Installation problem label May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (53d3bfd) to head (3e3dced).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2720   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files         257      257           
  Lines       15021    15021           
=======================================
  Hits        14286    14286           
  Misses        735      735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valeriupredoi
Copy link
Contributor Author

CircleCI tests failing since a couple days now https://app.circleci.com/pipelines/github/ESMValGroup/ESMValCore/12941/workflows/3c5f5cd7-c8e9-4785-ab13-921b92f95f07/jobs/53811 - separate issue, needs investigating

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valeriupredoi
Copy link
Contributor Author

thanks, bud! Off to figuring out what the heck's up with Circle, any ideas?

@valeriupredoi valeriupredoi merged commit 7807f4f into main May 6, 2025
4 of 6 checks passed
@valeriupredoi valeriupredoi deleted the pin_restrictive_dask branch May 6, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants