Allow reading facets from filenames #2725
Open
+332
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows reading facets from filenames and also makes it much more flexible. Examples:
Internally, this uses the regex engine to do all the heavy lifting. For this, the templates are converted to regex patterns that include named capture groups, e.g.
Supersedes #1943.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
All checks below this pull request were successful--> I think the remaining Codacy issue can be ignored since it's probably not a good idea to mess with the__init__
method of adataclass
.To help with the number pull requests: