Refactor AsyncFileResponse: remove String _path #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor eliminates the private String _path member from the AsyncFileResponse class, replacing its functionality with a fixed-size char gzPath[MAX_PATH] buffer insife of function. The use of Arduino's dynamic String class has known drawbacks in memory-constrained or real-time systems, particularly due to heap fragmentation and unpredictable allocation behavior. By switching to a statically allocated C-style buffer, the implementation now benefits from improved memory determinism, reduced fragmentation risk, and overall lower memory overhead. In addition to reducing memory fragmentation and improving stability in embedded environments, this change also yields better execution speed. This change maintains behavioral equivalence.
me-no-dev
reviewed
Jul 18, 2025
|
#mathieucarbou and #me-no-dev |
Thank you very much for indicating compatibility with other devices.
mathieucarbou
requested changes
Jul 23, 2025
mathieucarbou
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AsyncFileResponse class to eliminate the private String _path member variable and replaces it with local variables to improve memory management in embedded environments. The change aims to reduce heap fragmentation and improve performance by avoiding dynamic String allocations.
- Removes the private String _path member from AsyncFileResponse class
- Replaces _path usage with local String variable gzPath in constructor for compressed file handling
- Maintains the same functionality while improving memory determinism
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/WebResponseImpl.h | Removes the private String _path member declaration from AsyncFileResponse class |
| src/WebResponses.cpp | Updates constructors to use local gzPath variable instead of storing path in member variable |
Co-authored-by: Copilot <[email protected]>
mathieucarbou
requested changes
Jul 24, 2025
mathieucarbou
approved these changes
Jul 24, 2025
|
@me-no-dev : can you please have a look again ? PR looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor eliminates the private String _path member from the AsyncFileResponse class, replacing its functionality with a fixed-size char gzPath[MAX_PATH] buffer insife of function.
The use of Arduino's dynamic String class has known drawbacks in memory-constrained or real-time systems, particularly due to heap fragmentation and unpredictable allocation behavior. By switching to a statically allocated C-style buffer, the implementation now benefits from improved memory determinism, reduced fragmentation risk, and overall lower memory overhead. In addition to reducing memory fragmentation and improving stability in embedded environments, this change also yields better execution speed. This change maintains behavioral equivalence.