Add PIL image regression feature #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Added release notes for version 2.9.0, including support for PIL.Image in ImageRegression.check.
Member
|
Thanks @ClementPinard, appreciate the PR! Could you please fix the tests? Thanks! |
Member
|
The parametrization in the test caused the expected files to change... could you fix that? Thanks! |
Given the image data has not changed a simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
ImageRegressionFixturecompatible not only with bytes but also with direct PIL.Image.Image objects.Most of the time when I use it, I have to convert my images to bytes only for them to be loaded back to PIL.
This PR tries to make it easier for people not familiar with bytes and image conversion