Ord attributes #10
Open
Ord attributes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mats-knmi @ritvje Please review it. This PR breaks the test, but we can fix it if we agree. |
ritvje
reviewed
Oct 6, 2025
| def_msg["properties"]["platform_name"] = "[" + nod + "]" | ||
|
|
||
| cc = str(nod)[:2].lower() | ||
| if def_msg["properties"]["naming_authority"] == "eu.eumetnet": |
There was a problem hiding this comment.
Is the idea that if the naming authority is already given in the message template, we don't change it? Or why is this if clause here?
There was a problem hiding this comment.
If it is a national product and the naming_authority is the default("eu.eumentnet"), the ingester updates naming_authority by country_naming_auth . Ingester skips this block when naming_authority was filled by NMS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new ODIM ACDD attributes.