[FTD #4] support circle for multi lines text, updated images #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasRump
force-pushed
the
bugfix/FTD-4-circled-text-breaks-in-multiple-lines
branch
from
2945b43 to
dbaecdf
Compare
jay-k98
requested changes
Jun 26, 2025
| @@ -57,7 +56,7 @@ class ClosedCirclePainter extends TextDecoratorPainter with CircleConstraints { | |||
| canvas.drawOval( | |||
| Rect.fromCenter( | |||
| center: centerOffset, | |||
| width: scaledHorizontalRadius, | |||
| width: size.width * 1.1, | |||
There was a problem hiding this comment.
Can we implement this magic number as a param?
Comment on lines
+48
to
+49
| final scaledVerticalRadiusBottomCircle = circleSize.verticalRadius * 3.5; | ||
| const verticalOffset = 2.5; |
There was a problem hiding this comment.
The centering looks off now and this makes the circle still overlap the circle. See:
documentation/img/circle.png
Outdated
There was a problem hiding this comment.
The vertical centering looks off here
Comment on lines
+55
to
+56
| final scaledHorizontalRadius = circleSize.horizontalRadius * 2; | ||
| final scaledVerticalRadiusBottomCircle = circleSize.verticalRadius * 3; |
There was a problem hiding this comment.
Can we make those magic numbers as params?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Fix: Multi-line circle rendering issue
📌 Related Issue
Closes #4
✅ What’s Changed
This PR updates the circle styling logic to ensure that multi-line text is consistently circled inline. Previously, the circle was rendered inside the text , leading to inconsistent and visually incorrect results.
Additionally, I changes the open circle default and added functionalities to change the open site manually.
🔍 Confirmation
📸 Before / After