Lyd/unsupported pub

[lydiagarms]

Summary

This PR fixes two bugs in test/real-world-zapps/Voting.zol:

• Only a small subset of types are supported for secret variables. However, we should do the same for public variables that interact with secret ones, as discussed in Create errors for unsupported types for public variables that interact with secrets #486. In Voting.zol although the bytes32 variables are public variables, they interact with secret ones and so we must use bytes20 which is supported.
• There is a bug in deployment due to two variables being created with the same name. This is because the constructor is input a public address _admin. The default address is automatically used for public addresses, and so _admin is set to that. However, because _admin is also input to the deployment via the cnstrctr.mjs file.

Related Issues

• Create errors for unsupported types for public variables that interact with secrets #486
• Always use default addresses for constructor inputs #485

Checklist

• Tests added/updated
• CI passes
• No secrets/keys committed
• Docs updated (if needed)
• Backwards compatible (or noted breaking change)

How to test

1. Test Voting.zol in real-world-zapps.

Screenshots / Evidence (if applicable)

[SwatiEY]

LGTM

[github-actions]

🎉 This PR is included in version 1.10.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀