Run closeContainer synchronously and pause scripts for 1 tick. Fixes #141

Author: Earthcomputer

docs/clientcommands.ts

@@ -245,7 +245,8 @@ declare class ControllablePlayer extends Player {
     openContainer(entity: Entity, expectedContainerType: string | ((containerType: string) => boolean)): boolean;
 
     /**
-     * Closes the currently opened container, if any is open
+     * Closes the currently opened container, if any is open. Due to a threading issue in 1.16, this method delays
+     * the script by 1 tick, if a container was open.
      */
     closeContainer(): void;
 

src/main/java/net/earthcomputer/clientcommands/script/ScriptPlayer.java

@@ -354,8 +354,10 @@ private boolean openContainer0(BooleanSupplier rightClickFunction, Object contai
     }
 
     public void closeContainer() {
-        if (getPlayer().currentScreenHandler != getPlayer().playerScreenHandler)
-            getPlayer().closeHandledScreen();
+        if (getPlayer().currentScreenHandler != getPlayer().playerScreenHandler) {
+            MinecraftClient.getInstance().execute(getPlayer()::closeHandledScreen);
+            ScriptManager.passTick();
+        }
     }
 
     public int craft(Object result, int count, String[] pattern, JSObject ingredients) {