✨️ Add cache update feature #1549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirtangajjar
commented
Jul 14, 2021
| @@ -7,7 +7,7 @@ | |||
| /** | |||
| * Base EE Model class. | |||
| */ | |||
| abstract class Base { | |||
| abstract class Base extends \ArrayObject { | |||
There was a problem hiding this comment.
This was needed for site type PHP and wp where some existing methods were called. Those methods were called in site create too where they use array index to access properties. In site update, we use object property accessor to get the values.
|
Made PR from correct branch - #1550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
EasyEngine/site-command#387
EasyEngine/site-type-php#87
EasyEngine/site-type-wp#194