-
Notifications
You must be signed in to change notification settings - Fork 2
Fix: parentCommentId 전달x 해결 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kjhh2605, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 댓글 작성 시 parentCommentId가 올바르게 처리되지 않던 문제를 해결합니다. 이제 대댓글 작성 시 부모 댓글의 ID를 선택적으로 전달할 수 있으며, 시스템은 이를 기반으로 댓글 계층 구조를 정확하게 저장하고 응답에 사용자 ID를 포함합니다.
Highlights
- 댓글 계층 구조 지원 강화: CommentConverter와 CommentServiceImpl에서 부모 댓글 정보를 처리하는 로직을 추가하여 대댓글 기능을 지원합니다.
- parentCommentId 선택적 처리: CommentRequestDTO에서 parentCommentId 필드의 @NotNull 제약 조건을 제거하여, 부모 댓글이 없는 일반 댓글도 작성할 수 있도록 유연성을 높였습니다.
- 응답에 사용자 ID 포함: 댓글 작성 응답 DTO에 userId를 추가하여 댓글 작성자를 명확히 식별할 수 있도록 개선했습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
전반적으로 댓글 생성 시 parentCommentId가 전달되지 않던 문제를 잘 해결하셨습니다. DTO, Converter, Service의 변경 사항이 올바르게 적용되었습니다. 다만, 서비스 로직의 가독성을 높이기 위한 제안을 하나 드립니다.
src/main/java/EatPic/spring/domain/comment/service/CommentServiceImpl.java
Show resolved
Hide resolved
2anizirong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅇㅋ 굳~
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)