-
Notifications
You must be signed in to change notification settings - Fork 2
Bug: 메서드에 @Transactional 어노테이션을 추가 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
클래스 전체에
@Transactional을 적용하면 모든 public 메서드가 트랜잭션 내에서 실행되도록 보장할 수 있어 좋습니다. 하지만 이 클래스에는 읽기 전용(read-only) 메서드도 다수 포함되어 있습니다. 이 메서드들까지 기본적으로 read-write 트랜잭션으로 실행되어 성능에 미미한 손해를 볼 수 있습니다.더 나은 접근 방식은 클래스 레벨에는
@Transactional(readOnly = true)를 선언하여 기본적으로 모든 메서드를 읽기 전용 트랜잭션으로 만들고, 데이터 변경이 필요한 쓰기 메서드(예:signup,loginUser,blockUser등)에만@Transactional어노테이션을 개별적으로 붙여주는 것입니다.이렇게 하면 코드의 의도가 더 명확해지고 읽기 작업에 대한 성능 최적화도 기대할 수 있습니다.