-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Welcome @I-MirzaBaig! Thank you so much for your first pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for contributing.
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the comma at the end of line 17
Had re-editted the error!, Please review it again1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename your filename to your username.json
.
It should be I-MirzaBaig.json
. 🛠
OK! |
Updated File name !
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks! 👍
Thanks a lot!
Got to learn soo much!
…On Fri, Jan 6, 2023, 22:37 Priyanshu kumawat ***@***.***> wrote:
Merged #2762 <#2762>
into main.
—
Reply to this email directly, view it on GitHub
<#2762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3OCRGQCC5T4MPSBEFW5ITTWRBGMBANCNFSM6AAAAAATS5MTBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers