Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

MirzaBaig #2762

Merged
merged 3 commits into from
Jan 6, 2023
Merged

MirzaBaig #2762

merged 3 commits into from
Jan 6, 2023

Conversation

MiirzaBaig
Copy link
Contributor

@MiirzaBaig MiirzaBaig commented Jan 6, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Welcome @I-MirzaBaig! Thank you so much for your first pull request!

@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jan 6, 2023
Copy link
Member

@accodes21 accodes21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing.

@MiirzaBaig
Copy link
Contributor Author

Looks great, thanks for contributing.

Thank you!
This was my first contribution, well!, I enjoined alot, got to learn lots of error etc!

Copy link
Member

@dan-mba dan-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comma at the end of line 17

Had re-editted the error!, Please review it again1
Copy link
Member

@dan-mba dan-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your filename to your username.json.

It should be I-MirzaBaig.json. 🛠

@MiirzaBaig
Copy link
Contributor Author

Please rename your filename to your username.json.

It should be I-MirzaBaig.json. 🛠

OK!

@github-actions github-actions bot added the LGTM label Jan 6, 2023
@MiirzaBaig
Copy link
Contributor Author

Please rename your filename to your username.json.

It should be I-MirzaBaig.json. 🛠

Done

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! 👍

@kumarsonsoff3 kumarsonsoff3 merged commit 5931129 into EddieHubCommunity:main Jan 6, 2023
@MiirzaBaig
Copy link
Contributor Author

MiirzaBaig commented Jan 6, 2023 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants