loginUi: Add ChangeUsernameScene
#244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/change-username
branch
from
4495848 to
6ed3e78
Compare
swansontec
requested changes
Jun 13, 2025
swansontec
requested changes
Jun 16, 2025
| onComplete({ username: newUsername }) | ||
| account | ||
| .changeUsername({ username: newUsername, password }) | ||
| .catch(error => console.error(error)) |
There was a problem hiding this comment.
Please make handleNext async, and then just await the account.changeUsername. Then the button will spin until it's done, and you get error handling for free.
Jon-edge
force-pushed
the
jon/change-username
branch
from
85455b5 to
2bd01e3
Compare
swansontec
approved these changes
Jun 24, 2025
Jon-edge
force-pushed
the
jon/change-username
branch
from
2bd01e3 to
0c7fd09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none