Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
===========================================
- Coverage 44.52% 34.39% -10.14%
===========================================
Files 108 102 -6
Lines 13268 3175 -10093
Branches 630 776 +146
===========================================
- Hits 5908 1092 -4816
+ Misses 7350 1935 -5415
- Partials 10 148 +138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@rickard-von-essen it seems the code coverage for web worker breaks with vitest v3. Can you please have a look? You can see that this PR changes the code coverage numbers, whereby it shouldn't actually. What happens here is that the web worker is excluded from the total, thus increasing the ratio tested/untested. |
Contributor
Author
|
Didn't notice that. I'll have a look in few days. |
Contributor
Author
|
185ee3e to
90475e0
Compare
Update vitest and companion packages (@vitest/coverage-v8, @vitest/ui, @vitest/web-worker, vite-tsconfig-paths, @vitejs/plugin-react) to v4. Remove deprecated coverage.all option (replaced by coverage.include in v4). Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitest,@vitest/coverage-v8,@vitest/ui,@vitest/web-worker)@vitejs/plugin-reactto ^4.5.0 andvite-tsconfig-pathsto ^5.1.4coverage.allconfig option (replaced bycoverage.includein v4)Coverage note
Codecov reports a ~10% drop in overall coverage. This is not a regression in test quality — vitest 4 uses AST-based branch detection which is significantly more thorough than the old v8-to-istanbul approach. It counts many more branches (e.g. optional chaining, ternaries, default parameters) that were previously invisible. Statement/line coverage is largely unchanged.
Test plan
🤖 Generated with Claude Code