Open
Conversation
…nload limit When downloading individual .yml backup files, all downloads were triggered simultaneously via forEach + link.click(). Chromium blocks rapid programmatic downloads after ~10, causing only model1* files to be saved. Changed to sequential downloads with a 200ms delay between each file. Added test verifying all 43 models are returned correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 34.95% 35.69% +0.73%
==========================================
Files 115 115
Lines 4288 4281 -7
Branches 1033 1033
==========================================
+ Hits 1499 1528 +29
+ Misses 2585 2544 -41
- Partials 204 209 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
freshollie
reviewed
Mar 12, 2026
freshollie
reviewed
Mar 12, 2026
freshollie
reviewed
Mar 12, 2026
As suggested in code review: - Replace manual Blob/link DOM manipulation with legacyDownload (js-file-download) - Use p-limit(5) for concurrency limiting instead of fully sequential reduce chain - Use delay() utility from shared/tools instead of raw setTimeout - Simplify test by mocking legacyDownload directly
freshollie
reviewed
Mar 13, 2026
…mize Chromium handling
freshollie
previously approved these changes
Mar 16, 2026
Collaborator
freshollie
left a comment
freshollie
left a comment
There was a problem hiding this comment.
If you tested as working, feel free to merge
…s Chromium's simultaneous download limit
Contributor
Author
After several tests, I discovered that the batches weren't always running correctly. I've made a small change that seems to be effective; images attached. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the backup download flow to address issues with downloading a large number of files simultaneously, and adds a test to ensure robust handling of bulk downloads. The main changes are grouped into improvements to the download logic and enhancements to test coverage.
Improvements to backup download logic:
BackupCreateFlow.tsxto download files sequentially with a delay, preventing Chromium's rapid download blocking when many files are downloaded at once. [1] [2]Test coverage enhancements:
backup.spec.tsto verify that downloading a large number of models (e.g., 43) works correctly and all files are present and valid.Bug reported on:
https://discord.com/channels/761870396085108757/854744834698379274/1481212834766655578