dev: add just and m4 - #54
Merged
Merged
Conversation
edgetx's Justfile drives its codegen recipes (fonts, cfn sort, YAML parsers, radio list, and the new sim_string_list.h generator), and CI there installs just itself on every run. Bake both into the dev image so local dev containers have them out of the box and edgetx's codegen_drift workflow can drop its per-run just install/pin. m4 is needed to regenerate radio/src/translations/sim_string_list.h from string_list.h and isn't part of Ubuntu's base or build-essential. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
pfeerick
added a commit
to EdgeTX/edgetx
that referenced
this pull request
Aug 28, 2026
The edgetx-dev image now ships just and m4 (EdgeTX/build-edgetx#54), so the per-job install/pin in the codegen drift action is redundant for anything running inside that image. The `changes` job keeps its own install since it runs on a bare ubuntu-latest runner, not the container. Depends on EdgeTX/build-edgetx#54 reaching ghcr.io/edgetx/edgetx-dev:latest before merging, or these jobs will fail with `just: command not found`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m4to theedgetx-devimage's apt packages — needed to regenerateradio/src/translations/sim_string_list.hfromstring_list.h, and not part of Ubuntu's base orbuild-essential.just(pinned viaJUST_VERSION, same version currently pinned in edgetx's CI) — edgetx'sJustfiledrives its codegen recipes (fonts, cfn sort, YAML parsers, radio list, and a new sim string list generator), and today its CI reinstallsjustfrom scratch on every run.Once this lands in
:latest, edgetx'scodegen_drift.yml/action.ymlcan drop the per-runjustinstall and version pin, and its devcontainer won't need apostCreateCommandaddition either.Test plan
devimage succeedsdocker run --rm ghcr.io/edgetx/edgetx-dev:<branch-tag> bash -c 'just --version && m4 --version'