Update UI for SD log period settings

[mha1]

fixes #2965

Changes:

• the log period range is now 0.1s to 25.5s
• upon creation of a new SD Logs SF the period is initialized to 1.0s
• text "Value" is changed to "Interval" to indicate parameter represents the log period
• text "Switch" is changed to "Trigger"

[Eldenroot]

Please ping all translators

[mha1]

Please ping all translators

how best to do this?

[Eldenroot]

I am not at home right now, maybe @HThuren could you please ping all of lang maintainers? Thank you

[HThuren]

I am not at home right now, maybe @HThuren could you please ping all of lang maintainers? Thank you

I ping them.

[HThuren]

Hi translators,

• HThuren DA
• @ParkerEde / @TheIsotopes DE
• @Eldenroot CZ
• @ulfhedlund SE
• @robustini IT
• @zyren CN / TW
• @ajjjjjjjj PL
• @ToshihiroMakuuchi JP

Maybe you want to translate "Period" in your language file, please.

[mha1]

Hi translators,

@ParkerEde / @TheIsotopes DE @gagarinlg / @Eldenroot CZ @ulfhedlund SE @robustini IT @zyren CN / TW @ajjjjjjjj PL @ToshihiroMakuuchi JP

Maybe you want to translate "Period" in your language file, please.

@HThuren they don't have the word. It's new with this PR

[HThuren]

Translate -
#define TR_PERIOD "Period"

[gagarinlg]

Wouldn't be "interval" a better choice than period?

[HThuren]

Wouldn't be "interval" a better choice than period?

New define ?
#define TR_INTERVAL "Interval"

@mha1 what do you think ?

[mha1]

Oxford dictionary definition of interval:
1.
an intervening time.
"after his departure, there was an interval of many years without any meetings"

a pause or break in activity.
"an interval of mourning"

Oxford dictionary definition of period:
2.
PHYSICS
the interval of time between successive occurrences of the same state in an oscillatory or cyclic phenomenon, such as a mechanical vibration, an alternating current, a variable star, or an electromagnetic wave.

[HThuren]

I think you decide, translate wanted for
#define TR_PERIOD "Period"

[mha1]

@HThuren Thanks for your support. How do you want to do this? Wait for the merge and then have individual PR's? Post translations here and me doing further commits?

[HThuren]

@HThuren Thanks for your support. How do you want to do this? Wait for the merge and then have individual PR's? Post translations here and me doing further commits?

When this only are one define, I think the simplest way are to have them here from the translators, and you merge in own branch. The way with PR in your fork/branch are - i think - too much in this case.
No long wait, translators are very active :-)

[HThuren]

Hi translators, (maybe there where som confusion)

@ParkerEde / @TheIsotopes DE
@gagarinlg / @Eldenroot CZ
@ulfhedlund SE
@robustini IT
@zyren CN / TW
@ajjjjjjjj PL
@ToshihiroMakuuchi JP

Maybe you want to translate "Period" in your language file, please.
Provide in this thread your translation of:

#define TR_PERIOD "Period"

[pfeerick]

When we can, we're trying to include translations as part of main PR. And just to add to the confusion on period vs interval :-P

IMO interval is indeed the more correct - period describes the entire time, rather than the time between samples. Hence the use of "period" in when defining interval ;)

[HThuren]

Why dont we make both defines, and the discussion will be which one to choose by programmer.
#define TR_PERIOD "Period"
#define TR_INTERVAL "Interval"

[pfeerick]

Sounds good... the unused one now will probably get used in the future anyway.

[HThuren]

DK translation
#define TR_PERIOD "periode"
#define TR_INTERVAL "interval"

[mha1]

@pfeerick We really should use frequency in Hz but we would end up with kinda small values :-).

https://www.mathsisfun.com/algebra/amplitude-period-frequency-phase-shift.html
https://en.m.wikipedia.org/wiki/Frequency

I'm ok with whatever you choose.

[mha1]

DK translation
#define TR_PERIOD "periode"
#define TR_INTERVAL "interval"

@HThuren is it ok to start with a lower case letter?

[HThuren]

DK translation
#define TR_PERIOD "periode"
#define TR_INTERVAL "interval"

@HThuren is it ok to start with a lower case letter?

arhg, no both must have capital first letter.
#define TR_PERIOD "Periode"
#define TR_INTERVAL "Interval"

[ajjjjjjjj]

PL

#define TR_PERIOD "Okres"
#define TR_INTERVAL "Interwał"

[MicheleVilla]

IT Italian translation

#define TR_PERIOD "Periodo"
#define TR_INTERVAL "Intervallo"

[TheIsotopes]

DE

#define TR_PERIOD "Zeitraum"
#define TR_INTERVAL "Intervall"

[mha1]

@ParkerEde @TheIsotopes

I am very sure the German word for period is Periode.

Studyflix:
"Um die Frequenz zu berechnen, wird der Kehrwert der Periode T genutzt, also f = 1/T"

[TheIsotopes]

@mha1

imo Zeitraum is more comfortable than Periode.

Floskel / Phrase:
"In einem Zeitraum von 0,5 sekunden ..."

Just think of the women. ;-)

@ParkerEde What's your opinion?

[mha1]

@philmoz SF page looks great.
@pfeerick I think migration was successful so I'd like to call it a day here.
@ulfhedlund @HThuren Any further updates to translations should be done via PR #3082

Thanks for the great collaboration to Y'all

[HThuren]

Hi @mha1, after - as agreed - compiled all language DA EN DE CZ SE IT CN TW PL JP, all compile the radio part, but TW.
(I only compile FrSky X10s)

[mha1]

you mean tw is broken?

[HThuren]

you mean tw is broken?

right,
TR_SF_SWITCH and TR_PERIOD are missing in tw.h

[mha1]

Thanks, I'll fix it.

[mha1]

@HThuren I updated tw.h. Please try again.

[HThuren]

@HThuren I updated tw.h. Please try again.

I do it now

[HThuren]

Well done, TW now compile for radio (and companion)
@zyren you maybe want to translate #define TR_PERIOD "Period" and #define TR_INTERVAL "Interval" in PR #3082

[mha1]

@HThuren Awesome, thank you very much for going through all languages. I think we covered all bases now.

[HThuren]

@mha1 , try to update one of the files to restart the automatic check (only way I know of to do this)

[pfeerick]

One minor change - to always use STR_SF_SWITCH for the sf switch text - i.e. it will always be Trigger regardless of the SF, unless the wording is changed later...

[mha1]

@pfeerick Thanks for merging this. To remove the logic to switch between STR_SWITCH and STR_SF_SWITCH entirely you can delete the line StaticText *sfSwitchText = nullptr; and change sfSwitchText = new StaticText(line, rect_t{}, STR_SF_SWITCH, 0, COLOR_THEME_PRIMARY1); to new StaticText(line, rect_t{}, STR_SF_SWITCH, 0, COLOR_THEME_PRIMARY1);

[pfeerick]

Good point, thanks... I'll do that now before I forget as I don't think it will need to change dynamically just yet 😆

[zyren]

---

CN
#define TR_PERIOD "周期"
#define TR_INTERVAL "间隔"

---

---

TW
#define TR_PERIOD "週期"
#define TR_INTERVAL "間隔"

---