Repository navigation
Hand note att scope - #92
Merged
Merged
Conversation
peterstadler
approved these changes
Oct 6, 2026
peterstadler
left a comment
Member
There was a problem hiding this comment.
Looks generally good to me
peterstadler
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits possible values for
handNote/@scope.@scope="sole"is allowed@scope="sole"cannot be accompanied by additionalhandNotes@scope="major"requires at least one@scope="minor"Additionally it might be good to add that a
@scope="minor"needs at least one@scope="major"but there are too many files that don't specifically declare a hand for the author and just use a minor scoped hand for the deviating hand, so I left that out for now.This PR also added "actor" to the includes list for sources specs, which is already in the generated ODD's since abc13d9 but somehow slipped through in the
src/Specsitself.