Skip to content

Hand note att scope - #92

Merged
SteffenAstheimer merged 3 commits into
developfrom
handNote-attScope
Oct 6, 2026
Merged

SteffenAstheimer merged 3 commits into
developfrom
handNote-attScope

Conversation

@SteffenAstheimer

Copy link
Copy Markdown
Contributor

This PR limits possible values for handNote/@scope.

  • only one @scope="sole" is allowed
  • a @scope="sole" cannot be accompanied by additional handNotes
    • in hindsight, that makes the first rule kind of redundant
  • a @scope="major" requires at least one @scope="minor"
    • this should prevent to use "major" instead of "sole"

Additionally it might be good to add that a @scope="minor" needs at least one @scope="major" but there are too many files that don't specifically declare a hand for the author and just use a minor scoped hand for the deviating hand, so I left that out for now.

This PR also added "actor" to the includes list for sources specs, which is already in the generated ODD's since abc13d9 but somehow slipped through in the src/Specs itself.

@SteffenAstheimer SteffenAstheimer self-assigned this Oct 1, 2026
@SteffenAstheimer SteffenAstheimer added this to the Release 4.15 milestone Oct 1, 2026

@peterstadler peterstadler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me

Comment thread src/Specs/schemaSpec-sourcesTEI.odd.xml
Comment thread src/Specs/common-specs.odd.xml
@SteffenAstheimer
SteffenAstheimer merged commit 44dbd84 into develop Oct 6, 2026
@SteffenAstheimer
SteffenAstheimer deleted the handNote-attScope branch October 6, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants