-
Notifications
You must be signed in to change notification settings - Fork 19
Mongoid 9 support #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The test failure is also present with Mongoid 7 and 8.1. Just to confirm that it's not related to your changes. |
@ElMassimo any plans to review / merge this? |
I don't understand the silence, he is not dead because he has pushed to another repo few hours ago. |
@cperezabo only guess I have is he has notifications turned off for this repo or something. |
@ElMassimo any plans merge this? |
@ElMassimo checking in to see if this might get merged soon? |
I haven't used MongoDB or Mongoid for the past 5 years, so I no longer have a way to thoroughly test these changes. Happy to transfer the library to @danarnold if interested, or to |
@ElMassimo Sure, can you transfer ownership to the org https://github.com/cacheventures (which I'm a member of)? |
Mongoid seems to have moved the functionality from
Mongoid::Association::Referenced::Eager::Base
intoMongoid::Association::Eager
. Changing the prepend to work on that module seems to make everything work as expected.Additionally, I updated the Gemfile.lock to get the tests running. I am getting one test failure, on
Mongoid::Includes::Criteria#includes multiple inclusions through polymorphic associations :with inclusions should not be overriden
(expected: 4 times with any arguments
,received: 3 times with any arguments
). However, this also fails without any changes related to mongoid 9, so I don't think it's related to any changes I made. I also needed to add aTime.zone
specification to the spec_helper, which is now required by mongoid.