fix: handle test series names with multiple dashes in fix_series#6
Open
xickomesquita wants to merge 1 commit intoElasticRun:masterfrom
Open
fix: handle test series names with multiple dashes in fix_series#6xickomesquita wants to merge 1 commit intoElasticRun:masterfrom
xickomesquita wants to merge 1 commit intoElasticRun:masterfrom
Conversation
The previous code assumed the series name had exactly one dash (e.g.
'TestData-7'). When the name contained more dashes (e.g. 'TestData-foo-7'),
`int(parts[0].split('-')[1])` raised a ValueError.
Now extracts the numeric part from the last segment, with a safe fallback
to 0 on any parse error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix_series()inrun_test.pyassumed series names had exactly one dash (e.g.TestData-7), extracting the number withsplit('-')[1]ValueErrorand breaking the test runner series counterFix
Extract the numeric part from the last dash-separated segment instead of the second one, with a
try/exceptfallback to0on any parse error:Test plan
ValueError0