wallet: allow mintxfee=0 #1333
wallet: allow mintxfee=0 #1333
Conversation
This check for 0 feerate was inherited from upstream, and subsequently removed in this commit: bitcoin/bitcoin@f11eb1f
There was a problem hiding this comment.
HasValidFee is a consensus check (in CheckTxInputs) which was introduced with CA.
I'm not sure why the fee == 0 was originally added, as a transaction without any fee output (i.e. also zero fee) is consensus valid. (the fee == 0 check in only applied to individual fee outputs, not the total fees for the tx).
I've verified that removing this fee == 0 check will cause a hard-fork if a zero fee output tx is confirmed in a block.
Suggestion: we add a -con_ config parameter (e.g. -con_allowanyfee) that removes this optionally.
| @@ -30,8 +30,9 @@ bool HasValidFee(const CTransaction& tx) { | |||
| CAmount fee = 0; | |||
| if (tx.vout[i].IsFee()) { | |||
| fee = tx.vout[i].nValue.GetAmount(); | |||
| if (fee == 0 || !MoneyRange(fee)) | |||
There was a problem hiding this comment.
I believe so, thanks for catching this
I think that part was inherited from upstream initially
Good idea, thanks |
Allow
-mintxfee=0, so the elements wallet can create transactions with 0 value fee outputs.Elements can already accept 0 value fees with
-minrelaytxfee=0and-blockmintxfee=0, but before this change the wallet would not create a transaction with 0 feerate.Note: this check for 0 was inherited from upstream and subsequently removed in bitcoin/bitcoin@f11eb1f