Tracing: fix recent bug, and ensure CI actually tests it #8247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a crash right now, which passed CI! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
fix-tracing-ci
branch
from
a78c7ef to
c8bc78e
Compare
It's convenient to have pointers, but we have to do fixups. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
notleak() doesn't work for lightningd since the first span is created before memleak (or anything else!) is initialized, so we have to mark it manually. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
fix-tracing-ci
branch
from
ef3a9e7 to
ec6129a
Compare
rustyrussell
changed the title
``` pseudorand_u64 called! Aborted (core dumped) make: *** [Makefile:786: unittest/plugins/bkpr/test/run-bkpr_db] Error 134 ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a crash right now, which passed CI. This turns it on in our main CI build, and fixes the bug.
Changelog-None