Skip to content

Conversation

s373nZ
Copy link
Contributor

@s373nZ s373nZ commented Sep 15, 2025

I'm noticing a lot of entries in the debug log as such:

439Z DEBUG lightningd: Printing

There doesn't seem to be any other helpful information. Assumption is that this was a debugging exercise that wasn't fully removed, but I could be wrong. This PR removes that line in the listdatastore RPC.

Changelog-None

Important

25.12 FREEZE October 27th: Non-bugfix PRs not ready by this date will wait for 26.03.

RC1 is scheduled on November 10th

The final release is scheduled for December 1st.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@s373nZ
Copy link
Contributor Author

s373nZ commented Sep 15, 2025

A closer look at this function shows a few other debug log entries including:

  • Looking for:
  • Got: (which does appear in my logs)
  • Too long

Maybe these should all be removed as well, but I'm lacking context.

@s373nZ s373nZ force-pushed the remove-debug-printing branch from 1c2020e to 0c80dd6 Compare September 15, 2025 08:50
@s373nZ
Copy link
Contributor Author

s373nZ commented Sep 15, 2025

Removed the additional debug logging statements described in #8548 (comment).

@s373nZ s373nZ changed the title fix: Remove "Printing" from listdatastore debug log. fix: Remove "Printing" (and related) from listdatastore debug log. Sep 15, 2025
@rustyrussell rustyrussell merged commit b49ccfa into ElementsProject:master Sep 16, 2025
139 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants