Listpays still pending db fix #8654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
listpays-still-pending-db-fix
branch
from
62e2428 to
dd5de2e
Compare
…y have HTLCs. And don't fix up a genuine pending one! Signed-off-by: Rusty Russell <[email protected]>
…s no htlc. Changelog-Fixed: JSON-RPC: `listpays`/`listsendpays` erroneously left `pending` in xpay are cleaned up. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
listpays-still-pending-db-fix
branch
from
dd5de2e to
8a9a04f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on #8635 for first two commits)
This fixes up prior occurrences of payments being listed as "pending". It's a separate PR because we try not to put db changes into point releases.