lightningd: fix race with mutual connect. #8698
Merged
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65dccea "pytest: fix flake in test_reconnect_signed" accidentally introduced a bug, where the connect command may not return. If we call "connect" while a connection is still being processed through the peer_connected hooks, we would call peer_channels_cleanup(), which (if the peer has no channels) would free the peer. Then when the peer_connected hook returned, it would lookup the peer, see it was gone, and silently return. The connect_succeeded() function was never called, and the connect command never woken. Signed-off-by: Rusty Russell <[email protected]> Changelog-None: bug introduced this release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
65dccea "pytest: fix flake in test_reconnect_signed" accidentally introduced a bug, where the connect command may not return.
If we call "connect" while a connection is still being processed through the peer_connected hooks, we would call peer_channels_cleanup(), which (if the peer has no channels) would free the peer.
Then when the peer_connected hook returned, it would lookup the peer, see it was gone, and silently return. The connect_succeeded() function was never called, and the connect command never woken.
Changelog-None: bug introduced this release.