Conversation
Fix crash caused by deleting buffer we do not own
The symbol will be defined as 1 as long as the BUILD_HEADLESS CMake var is a truthy value.
Merge develop into headless renderer
Decouple BUILD_HEADLESS CMake option from preprocessor symbol
Cmake sdl2 target fix
Merge develop
There was a problem hiding this comment.
I think these config changes shouldn't be included because I was just adding them to get the test loop to run in colab. but then it turned out that only empty frames were sent from minetest.
|
Overall I am not quite sure why we would want to merge this now. We already have the semi headless mode using Xvfb. What would be good to know is if there is a performance difference between the current state of develop and this branch. |
| ${GMP_INCLUDE_DIR} | ||
| ${JSON_INCLUDE_DIR} | ||
| ${LUA_BIT_INCLUDE_DIR} | ||
| ${SDL2_INCLUDE_DIR} |
| ${ZMQ_INCLUDE_DIR} | ||
| ${ZMQPP_INCLUDE_DIR} | ||
| ${SQLITE3_INCLUDE_DIR} | ||
| ${SDL2_INCLUDE_DIR} |
| @@ -1,4 +1,5 @@ | |||
| name = MinetestAgent | |||
| update_last_checked = 1670529488 | |||
| ${X11_LIBRARIES} | ||
| ${SOUND_LIBRARIES} | ||
| ${SQLITE3_LIBRARY} | ||
| ${SDL2_LIBRARY} |
|
|
||
| # Optional user provided library folder | ||
| lib/irrlichtmt | ||
| # TODO: don't add irrlichtmt, apply patch from CMakeLists.txt |
|
|
||
|
|
||
|
|
||
| if(BUILD_CLIENT AND BUILD_HEADLESS) |
There was a problem hiding this comment.
This should not be in both CMakeLists.txt and src/CMakeLists.txt.
| # Set some random things default to not being visible in the GUI | ||
| mark_as_advanced(EXECUTABLE_OUTPUT_PATH LIBRARY_OUTPUT_PATH) | ||
|
|
||
| if(BUILD_CLIENT AND BUILD_HEADLESS) |
There was a problem hiding this comment.
This should not be in both CMakeLists.txt and src/CMakeLists.txt.
| if (!raw_image) | ||
| return; | ||
|
|
||
| // warningstream << "got data" << raw_image->getDimension().Width << std::endl; |
5 participants
Add compact, short information about your PR for easier understanding:
To do
This PR is a Work in Progress
How to test
make -j8 && python hacking_testing/test_loop.py