-
Notifications
You must be signed in to change notification settings - Fork 11
Create Docker container setup for the project #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
||
WORKDIR minetest | ||
EXPOSE 30000 | ||
CMD ["hacking_testing/server.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this got me wondering, will we need a separate Dockerfile for clients?
If this is specifically for running a server then we actually don't need to build with SDL at all.
On the other hand, I guess initially we will have server and client(s) running on the same machine, maybe even the same docker container..
So in case of a single Dockerfile it probably would make sense to not hardcode the entry point here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMD is just a default, we could make a cli with support for the different options as an entry point maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that sounds good. even simpler: optionally pass a any script that is being used as entrypoint
This pull request creates a Docker container setup for the alignment-minetest project. (solves #42)
This PR is a Work in Progress.
To do