Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (ESLint v9 and test libraries) #600

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

pioug
Copy link

@pioug pioug commented Apr 27, 2024

Big PR, lots of changes, but I hope that you don't mind because the repo is not actively maintained anyway 💦

  • Replace Travis with GitHub actions/workflows
  • Update test libraries (mocha, chai, istanbul ➡️ nyl)
  • Update tooling (replace Gulp with npm commands)
    • Gulp on its own is quite heavy
    • Wrapper plugins like gulp-eslint and gulp-istanbul are not really maintained and locked on older versions. I am a fan of Gulp, but in this case, using the CLI without extra dependencies is necessary to lower the maintenance cost for this kind of project.
  • Remove the yarn lockfile, package-lock.json is more than enough
  • Remove unused dependencies
  • Update ESLint configuration and support v9 (https://eslint.org/docs/latest/use/migrate-to-9.0.0)

Test cases must be unique. Identical test cases can cause confusion and be hard to detect manually in a long test file. Duplicates are now automatically detected and can be safely removed.

I use this plugin at BandLab, so I don't mind spending some time on it if necessary. If you're looking for a maintainer, I volunteer! Last resort for me would be publishing my fork. I can break down the PR if you prefer, but I'm not sure if it's time-savvy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant