-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create website for testing Token generation #16 #17
Conversation
@dmohns can i get your review |
Nice, thanks @munyanezaarmel the website look good. However, you are essentially hardcoding the entire repositories code into the HTML file, which is not exactly what we want. Could me make it more like this:
Build the website using |
Hello @dmohns, Thank you for your review. I've decided to proceed with React/Next.js for my project. However, I'm encountering an issue with package accessibility. Despite successful installation, I'm unable to access the package in my code.
For reference, I'm looking for something similar to the documentation style found on the npm website for packages like 'decoders' (https://www.npmjs.com/package/decoders). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments in the code.
Could you move the entire website generation code into a folder called website
rather than openpaygo-token-generator
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you fix the failing linters, then we can merge this
Brief summary of the change made
Closes: #16
Are there any other side effects of this change that we should be aware of?
none
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.