token shared lib: Implement missing functions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement missing features in shared library needed to get encoder/decoder to function properly. Also fix the accuracy issue with siphash lib by using hex values.
dmohns
reviewed
May 29, 2024
lib/siphash.js
Outdated
| /* |
There was a problem hiding this comment.
Instead of copy/pasting the source code here, could you pull this as an npm dependency? If I'm not mistaken it's this one: https://www.npmjs.com/package/siphash
There was a problem hiding this comment.
That's the one, sure I could make it happen.
There was a problem hiding this comment.
Updated, please have a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement missing features in shared library needed to get encoder/decoder to function properly. Also fix the accuracy issue with siphash lib by using hex values.
Majority of test cases are now passing for encoder/decoder modules, still need to fix failing cases;
convertToNdigitTokenseems broken or needs to be modified to work properly.