port: fix failing test + support extended token #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmohns
reviewed
Jul 8, 2024
Comment on lines
72
to
74
| static convertFrom4digitToken(token) { | ||
| // 4 - digit token value | ||
| let bitArray = [] | ||
| for (let digit of token.toString()) { | ||
| digit = Number(digit) - 1 | ||
| const tempArr = bitArrayFromInt(digit, 2) | ||
| bitArray = bitArray.concat(tempArr) | ||
| } | ||
| return bitArrayToInt(bitArray) | ||
| return convertFrom4digitToken(token) | ||
| } |
There was a problem hiding this comment.
Is it required to have the function convertFrom4digitToken twice? As a class function and as a global? This functional declaration seems a bit odd to the viewer.
There was a problem hiding this comment.
It does look odd, but the reason for it is to avoid duplicating the function in both classes (shared/extended)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.