Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volumes in Docker Compose for data storage #29

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

dmohns
Copy link
Member

@dmohns dmohns commented Jan 25, 2024

Description

This PR changes the docker-compose.yml to use Docker volumes for data storage rather than host mounts.

Warning

After this PR is merged, developer's local databases will be empty and require to be seeded again.

Motivation

Using Volumes for data storage offers several benefits

  • Increased performance
  • Volumes are more cross-platform compatible than host file mounts. When you use volumes, you abstract away the underlying file system details of the host machine, making your setup more portable across different environments.
  • Volumes provide a level of isolation between the container and the host system.

@dmohns
Copy link
Member Author

dmohns commented Jan 25, 2024

@alchalade @InensusDev I will leave the coordination and alignment of merging this PR to you. Merging this PR will have impact on your existing development environments, as they will be empty after that. I think I would make sense to merge this PR only if no other features are currently getting worked on.

Please let me know what would be a good time to merge it 😉

@dmohns dmohns merged commit e39acac into main Mar 20, 2024
8 checks passed
@dmohns dmohns deleted the noref-use-volumes-in-docker-compose branch March 20, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants