Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unneeded NPM container #44

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

dmohns
Copy link
Member

@dmohns dmohns commented Feb 22, 2024

The UI is build in it's own Docker conainter from ui directory. Removing a leftover from previous design.

When we had

  'node':
    container_name: mpmanager_node
    build:
      context: Docker/
      dockerfile: DockerfileNpm
    volumes:
      - ./Website/htdocs/mpmanager:/home/node/app
    command:  /bin/sh -c "/tmp/start.sh"

in the Compose file, which no longer exists.

The UI is build in it's own Docker conainter from `ui` directory. Removing a leftover from previous design.

When we had

```
  'node':
    container_name: mpmanager_node
    build:
      context: Docker/
      dockerfile: DockerfileNpm
    volumes:
      - ./Website/htdocs/mpmanager:/home/node/app
    command:  /bin/sh -c "/tmp/start.sh"
```

in the Compose file, which no longer exists.
@dmohns dmohns marked this pull request as ready for review February 22, 2024 11:09
@dmohns dmohns merged commit 8ec7b9f into main Mar 4, 2024
8 checks passed
@dmohns dmohns deleted the chore-remove-uneeded-docker-images branch March 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants