chore: Cleanup JavaScript package-lock.json files
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmohns
changed the title
package-lock.json files
InensusDev
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the UI container doesn't seem to utilize any lockfiles. As a result each developer may end up with a different environment depending on when they build their container image.
Additional, there is a
package-lock.jsonin the root of the repository which was added here inensus/MPManager#112 which I don't think serves any purpose.Note
This does not affect the production image https://github.com/EnAccess/micropowermanager-cloud/blob/main/Website/ui/Dockerfile#L4 as this
package-lock.jsondoesn't seem to be copied into it. It's a separate task to adopt this behaviour for prod.