replace shard db connection in favour of tenant #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the docs are fully covered; I will need some help with how best to introduce this deprecation. |
beesaferoot
changed the title
dmohns
reviewed
Feb 11, 2025
There was a problem hiding this comment.
This is a massive change. Thank you for taking on that challenge 🙏
Let's do this in multiple steps. Let's first merge this PR and try to make double sure everything is working correctly after the changes.
I see 2 more ToDo's:
- Update the documentation
- Move the Tenant migrations from
micropowermanagersubfolder to a subfolder calledtenant
dmohns
previously approved these changes
Feb 11, 2025
beesaferoot
force-pushed
the
replace-shard-with-tenant
branch
from
d0a7c6a to
a7cae09
Compare
|
Fixed merge conflicts, now ready for review. @dmohns |
dmohns
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
With This PR we deprecate usage of
shardin favour oftenant.Update
READMEto reflect shard deprecation.Make progress on: #208
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.