feat(vucm): add integration with NI-cDAQ #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnovatorov
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Hi @anataty, thanks for your PR!
To check if linters are satisfied please run make lint locally.
examples/vucm/ni-daq/script.py
Outdated
Comment on lines
10
to
12
| def parse_bytes(bytes): | ||
| return bytes.decode("utf-8") |
There was a problem hiding this comment.
This function can be replaced with mybytes.decode() which is equivalent to mybytes.decode("utf-8").
examples/vucm/ni-daq/script.py
Outdated
Comment on lines
69
to
79
| break | ||
|
|
||
| await self.send_telemetry( | ||
| { | ||
| "status": parse_bytes(data_to_send), | ||
| } | ||
| ) | ||
| self.alerts.clear() | ||
|
|
||
| except Exception as e: | ||
| self.alerts.add("nidaq_error") | ||
| await self.log.error(f"failed to process data: {e}") | ||
|
|
||
| finally: | ||
| connection.close() | ||
| await asyncio.sleep(1) | ||
|
|
||
| except Exception as e: |
There was a problem hiding this comment.
You if break up there, then there'll be no exception to catch down here. Do we really need the inner try-except block?
anataty
force-pushed
the
ty/ni-daq/0
branch
2 times, most recently
from
7becb8f to
28834b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.