ci(release): stop release-please auto-merge loop - #330
Merged
Conversation
The release job deleted the release branch and re-dispatched itself when the PR had not merged within 60s. Because the PR was authored by GITHUB_TOKEN its CI never ran (action_required), so it never went green, auto-merge never fired, and the branch-delete + self-redispatch recreated the release PR every ~90s indefinitely. Mirror the working sister-app config: author the PR with RELEASE_PLEASE_TOKEN so CI runs on it, then just enable native auto-merge. The PAT-authored merge is a push to main that re-triggers this workflow to cut the release and the on:push deploy, so the delete/redispatch and explicit deploy dispatch are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-open of #325 (its branch was auto-deleted by
Delete closed PR branchwhen the PR closed, before it merged, so the fix never reached main and the loop resumed on re-enable).Root causes
gh workflow run $WORKFLOW) when the PR had not merged within its 60s wait loop.GITHUB_TOKEN→ CIaction_required(maintainer-approval gated) → never green → native auto-merge never fired → delete + redispatch recreated the PR every ~90s.Fix (mirror working sister-app Monete)
RELEASE_PLEASE_TOKENso CI runs on it without the approval gate.gh pr merge --rebase --auto. The PAT-authored merge is a push to main that re-triggers this workflow to cut the release and theon: pushdeploy.actions: writepermission.Merge order matters
Merge THIS first, THEN re-enable
Release Please.RELEASE_PLEASE_TOKENis already set.