Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying the name of the default pool to use #16

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

saraadams
Copy link
Contributor

Currently, it is only possible to specify the pool name of large actions. With this PR, you can also specify a custom pool name for all actions to be executed on. This is helpful if actions are not to be executed on the RBE service's default pool (used when no pool is specified).

Copy link

@Unnar Unnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks sound to me.

Copy link

@Unnar Unnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saraadams saraadams merged commit d3a4d5e into main Feb 12, 2025
@saraadams saraadams deleted the sara-default_pool branch February 12, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants