WIP: Create Hologram Publisher#323
Conversation
@dnowacki-usgs, I made these edits while taking my first look at your code. Thanks!!! The timing is good, since I'm also working on another publisher with EnviroDIY#324. My edits should only be to whitespace and doxygen-formated comments, so it should work identically to what you submitted. Can you confirm?
|
@SRGDamia1, should we point this PR to develop, or merge directly into master? Also, I haven't tested this on my own hardware. @dnowacki-usgs provides extra details on how to configure things in #305, so I might be able to try testing in over the next few weeks, but not right away. |
|
Hi @aufdenkampe thanks for the edits! I haven't had a chance to test them but they look good to me. I mentioned this (by linking to a gist) in #305, but this is how I generate the HologramAPI publisher in the logger .ino file: Note that |
|
@SRGDamia1, it's been a while since we actively discussed this, and the APIs have likely changed, but the benefits described in the following issue could still prove to be quite beneficial to our server-side bottlenecks at Model My Watershed. Here's the relevant issue thread, with the reasoning why this feature could be useful. |
This is code I wrote many months ago, recently updated to be mostly consistent with modern ModularSensors code formatting, that implements a publisher that uses the Hologram socket API. It is based off of EnviroDIYPublisher.cpp/EnviroDIYPublisher.h. There are a number of rough edges. In particular, the Hologram Device ID is currently hard-coded in HologramPublisher.cpp, and should really be set externally...I am not at all a C++ programmer. Would love input or modifications; I'm just putting this up here since there has been interest, particularly in #305.