-
-
Notifications
You must be signed in to change notification settings - Fork 50
Fix multi-pin power, add retries, remove refs to old data portal #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SRGDamia1
wants to merge
544
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 222 commits
Commits
Show all changes
544 commits
Select commit
Hold shift + click to select a range
7b8bb9c
Refactor SQ212, OBS3, and Cyclops to allow either processor or ADS1x1…
SRGDamia1 3d92c05
Use the AnalogVoltageBase for differential measurements for the Alpha…
SRGDamia1 c0f7c9e
More description of ADS I2C addresses
SRGDamia1 2f91e6e
Update ctor docs and delete copy and move ctors
SRGDamia1 4df6330
Change string construction
SRGDamia1 28aa021
update includes
SRGDamia1 dca3e7b
Add f tag to some floats
SRGDamia1 62cc333
Decrease variable scope
SRGDamia1 650302e
Made default voltage multiplier 1.0f
SRGDamia1 f634350
Disambiguate getSensorLocation
SRGDamia1 e7d704f
float tags
SRGDamia1 adc82fa
use OPERATING_VOLTAGE for invalid supply voltage
SRGDamia1 762c7ca
restructure string creation
SRGDamia1 1a9ad47
Use AnalogVoltageBase for AlalogEC and ALS
SRGDamia1 74e7b62
Comment change
SRGDamia1 fb8ae84
Some comments and float tags
SRGDamia1 cd5319a
const number values
SRGDamia1 2219914
Verify _analogVoltageReader was created
SRGDamia1 e287f78
Forward declaration
SRGDamia1 e2d3a9f
Validate channel
SRGDamia1 d735cd9
validate supply voltage
SRGDamia1 bf9137d
default values
SRGDamia1 d45e149
Remove stupid check
SRGDamia1 416464b
Remove un-necessary null checks
SRGDamia1 b518c3c
Update some comments
SRGDamia1 e620472
Consistent types for analog channels
SRGDamia1 1efc54d
float tag
SRGDamia1 d32c696
Check for valid load resistor
SRGDamia1 d1e28aa
Clarify use of supply voltage, clamp after saturation, use defines fo…
SRGDamia1 d6c5b9d
Move to initializer
SRGDamia1 01d1c51
docs and comments
SRGDamia1 2584b62
Revert "Remove un-necessary null checks"
SRGDamia1 000ea79
Fix some comments, float tags, magic numbers
SRGDamia1 27c47da
Fix analog voltage conversion
SRGDamia1 63b58f1
combine TIADS1x15 constructors
SRGDamia1 1e11b92
Channel docs
SRGDamia1 2432a52
Float tags
SRGDamia1 e94b62f
Add debugging
SRGDamia1 29f5a04
make epsilon a define
SRGDamia1 5e19ee3
float casts
SRGDamia1 dbe3d7f
Validation, spelling, move diff channel out of TIADS1x15Base
SRGDamia1 5f69ba4
Fix variable sizing
SRGDamia1 6dc7762
Define for PROCESSOR_ANALOG_MAX_CHANNEL
SRGDamia1 01b6515
Refactor getSensorLocation for analog to getAnalogLocation depending …
SRGDamia1 b43db51
Validation, docs, float tags
SRGDamia1 54c795d
Forward declarations, demote success where possible
SRGDamia1 35303c6
no -1 default for getAnalogLocation
SRGDamia1 56e02fb
Doc that default readers are for back compatibility
SRGDamia1 2c320f9
Rename macro
SRGDamia1 ca0da38
Refactor TIADS1x15Base to store and configure internal _ads, move par…
SRGDamia1 a3aaf41
Have ProcessorAnalog and TIADS1x15 take pointers to simplify ctors
SRGDamia1 1b60ac6
Use utility to make sure objects are really created and pointers are …
SRGDamia1 446a2e6
Typos, reorder, null validate
SRGDamia1 b91793c
Back to initializers
SRGDamia1 a663301
Lots of small fixes
SRGDamia1 44e7f83
Doc fixes, add develop as a base-ish branch
SRGDamia1 3ac2659
Updated change log, add some backwards compatibility warnings, fix so…
SRGDamia1 932c282
Spelling and grammar
SRGDamia1 78888c6
Delete copy and move constructors
SRGDamia1 e4f37e8
Update examples
SRGDamia1 293d602
Update examples again
SRGDamia1 900d41b
Add functions to calculate analog resolution via AI
SRGDamia1 0896125
Move function to convert a float resolution to a number of decimal pl…
SRGDamia1 212fe81
Update ChangeLog.md
SRGDamia1 180d230
Update ChangeLog.md
SRGDamia1 a074625
Update ChangeLog.md
SRGDamia1 e28b7bb
Implement a begin function for analog voltage classes and call it fro…
SRGDamia1 716dc77
Merge branch 'analog_stuff' of https://github.com/EnviroDIY/ModularSe…
SRGDamia1 a9ddcc4
Minor fixes
SRGDamia1 a132175
if the call to create new objects fails the stack is overflowing and …
SRGDamia1 ea9b009
Properly use ALPHASENSE_CO2_VOLTAGE_MULTIPLIER
SRGDamia1 14a9b03
Fix ctor order
SRGDamia1 14e138c
Merge pull request #495 from EnviroDIY/analog_stuff
SRGDamia1 618e7e5
First cut via AI. Does not work.
SRGDamia1 4d031e3
Switch to Rob Tillaart's library which reduces footprint with 32-bit …
SRGDamia1 95afec4
Use single common define for air pressure; correct var name for altitude
SRGDamia1 b58a6cb
Add static assert checks of defined values
SRGDamia1 ece4c57
Fix assertion checks
SRGDamia1 7e7860b
Fix setting of density, typo
SRGDamia1 313c8a5
Update src/sensors/YosemitechParent.cpp
SRGDamia1 e1254e5
Update setupGitFilters.bat
SRGDamia1 a6970e0
Change to bit shifting, add missing dtors, fix some typos and copy er…
SRGDamia1 91ec2b0
Fix docs
SRGDamia1 51ae698
Support second hardware I2C; fix name/location issue, fix validation,…
SRGDamia1 d4cdb7c
Prettier print out
SRGDamia1 a791940
Support secondary hardware I2C for ADS1x15
SRGDamia1 f5576b9
Rename validate fxn, remove math, use enums
SRGDamia1 6c9bd5c
Reorder ctor, fix wire calls
SRGDamia1 8d2b9d2
Some fixes and formatting
SRGDamia1 3e84f3e
Step down version until Adafruit creates a release
SRGDamia1 12bb263
Null checks on wire
SRGDamia1 4e026c1
AI suggested fixes
SRGDamia1 8df32e2
Update examples/ReadMe.md
SRGDamia1 81c97b2
Update src/sensors/ProcessorAnalog.cpp
SRGDamia1 5b56a33
Update src/sensors/AnalogVoltageBase.h
SRGDamia1 1e92944
Update TEConnectivityMS5837.h
SRGDamia1 8abbe83
Update TEConnectivityMS5837.h
SRGDamia1 8cec3b2
Update VariableArray.h to fix typo
SRGDamia1 c85a29a
Update src/sensors/ProcessorStats.cpp
SRGDamia1 2aadc43
Update GeoluxHydroCam.cpp
SRGDamia1 001f056
Align runtime check with static assert
SRGDamia1 1269d82
Document 8192 OSR
SRGDamia1 2b429fd
Clamp, move non-functional define to config and give warning
SRGDamia1 e4db6eb
Convert second and further constructors into delegating constructors …
SRGDamia1 8f59d26
loggerClock::setRTClock now returns TRUE when the clock was not set b…
SRGDamia1 e5e6aa7
Support using onboard NTP for modems where it's implemented
SRGDamia1 40c0388
minor debug change
SRGDamia1 aae713a
Fix compiler errors
SRGDamia1 3b129e3
Woops! 7080 doesn't give epoch!
SRGDamia1 9894d8f
Update examples/menu_a_la_carte/ReadMe.md
SRGDamia1 3c90e3a
Gave a default of 5 retries
SRGDamia1 825b3ac
Fix link
SRGDamia1 8467987
Fix _remainingShortIntervals size
SRGDamia1 83af33a
Add nullptr checks
SRGDamia1 eb6602c
Measurement retries as define for some with known
SRGDamia1 b6ffdd7
Mark failure when wake fails
SRGDamia1 7a9d656
Add define for failure value
SRGDamia1 4bfd28b
Add failure message
SRGDamia1 7e84d5f
Clamp in setup, not ctor
SRGDamia1 4c2ba65
Support modems that can get times internally as parts
SRGDamia1 318ae79
Reorder defines to put config on top
SRGDamia1 2066e94
Decimal[s] places?
SRGDamia1 ed9ded6
Decimal place[s] here
SRGDamia1 cfda215
Merge branch 'develop' into bar02
SRGDamia1 7edac17
Change default oversampling for BMP3xx
SRGDamia1 abc5d9e
Fancier pretty print check
SRGDamia1 0a8ab8b
Don't double validate OSR,, nitpicks
SRGDamia1 fa02708
Merge pull request #497 from EnviroDIY/bar02
SRGDamia1 00d183a
Fix NIST time from parts
SRGDamia1 d686efa
Fix compiler warning
SRGDamia1 986c1d3
Convert all -9999s to a defined MS_INVALID_VALUE
SRGDamia1 e290ccf
Use -9999, not -9999.0 as sentinel value
SRGDamia1 a03732e
Reduce some duplication
SRGDamia1 ef08e1e
Declared trivial destructors as default
SRGDamia1 26cdcad
Fix compiler warnings on getNISTTime
SRGDamia1 1880b6e
default a bunch more destructors
SRGDamia1 11b181d
Fix retries in the update function
SRGDamia1 17ca511
Save partially correct values
SRGDamia1 7103f53
Made destructors override where applicable
SRGDamia1 8b156d9
Add ifndef checks
SRGDamia1 784055b
Fix some comments, unmarked overrides
SRGDamia1 a99860b
Replace the many, many (void) functions with c++ style ()
SRGDamia1 bf646b2
added static_assert
SRGDamia1 05d7728
Change to c++ style static casts
SRGDamia1 c7f9f0c
Fix void call botched in find/replace
SRGDamia1 805c0d4
Switch to static_assert check
SRGDamia1 cf7cf9d
small changes
SRGDamia1 86a3e6f
Reserve strings in all implementations of getSensorLocation
SRGDamia1 71f99b9
Minor fixes
SRGDamia1 7cbf90e
clang format
SRGDamia1 78c720b
Null checks, debugs
SRGDamia1 19a0ce0
Initializers
SRGDamia1 be59a4d
Add yields
SRGDamia1 f719e6e
Fix virtual/override redundancies
SRGDamia1 73a70e5
Unique status codes
SRGDamia1 55a61ba
Fix some comments
SRGDamia1 246c0a4
Reorder ctors
SRGDamia1 36ebd4e
Extract method
SRGDamia1 62591e6
Reorder delegating constructors
SRGDamia1 427fd29
More constructor rearrangements
SRGDamia1 901f901
Add warnings about client deletion
SRGDamia1 3196497
Fix issues with sleep pin - not that it works, anyway
SRGDamia1 08022a7
Add warning about dumping buffer
SRGDamia1 670204a
check for finite value
SRGDamia1 1c5bdc4
Fix compiler order warning
SRGDamia1 fa65dae
Change type of did_respond
SRGDamia1 f9d2399
Handle timezone issues for mktime fxn
SRGDamia1 9af36e5
Reorder delegating ctors, fix remaining virtual/override, nitpicks
SRGDamia1 347eb0b
made initialTransmissions part of the dataPublisher
SRGDamia1 6c63c53
Rename retry related fxns/vars
SRGDamia1 3e73f7e
format
SRGDamia1 426ab65
Allow temp of 0, verified that TinyGSM should return -9999 for bad temp
SRGDamia1 8bf5d09
Fix overflow compiler warning
SRGDamia1 1dab51f
Added a config for MAX_NUMBER_SENSORS
SRGDamia1 dd6e5f9
Made the sensor list a parameter of the variableArray
SRGDamia1 2e47193
Modify sensorsPowerUp, sensorsWake, sensorsSleep, and sensorsPowerDow…
SRGDamia1 b396313
Check for matching pointers, instead of rechecking isLastVarFromSensor
SRGDamia1 34df435
Reduce repeats in begin, use _sensorList in setup
SRGDamia1 7db8a32
Extract code to check if a sensor can power down into a new function
SRGDamia1 828bc7e
Extract logic into helpers
SRGDamia1 8db978e
rename printSensorData to printVariableData with compatibility stub
SRGDamia1 1cc4d88
rename printSensorDataCSV to printVariableValuesCSV with compatibilit…
SRGDamia1 9c86135
Add function so sensor can print its own data
SRGDamia1 0cdc9c6
Remove arguments that aren't honored
SRGDamia1 9bcdaa2
Change type of tz_offset
SRGDamia1 be819ff
Fix some typos, spelling, virtual/override redundancy
SRGDamia1 02a6294
Update clang format; increase PenaltyReturnTypeOnItsOwnLine
SRGDamia1 d6803ea
Add debug bit opt to printSensorData
SRGDamia1 d7fbafe
Fix RSSI PWM
SRGDamia1 8c91fa6
Rename bumpMeasurementAttemptCount to finalizeMeasurementAttempt
SRGDamia1 ce9336f
Add define for HTTP_VERSION_PREFIX_LEN
SRGDamia1 432d6bf
Add some comments
SRGDamia1 2dbe12f
Initialization, null checks
SRGDamia1 87cb61d
Replace log fxn with builtin bit math
SRGDamia1 0cdcec0
Always add UUID row to header
SRGDamia1 2fecf3a
For real handle tz_offset with different types
SRGDamia1 91212b9
Lots of small changes
SRGDamia1 db756c1
Add helper for isPinLow
SRGDamia1 61ece2a
Add helper for sharesPowerPin
SRGDamia1 8f21784
Remove the pointer to a new object, create object only at use
SRGDamia1 e241027
Unify MaxBotix retries with rest of library
SRGDamia1 9627e6a
Clarify retries, simplify bit check for pin state
SRGDamia1 0d9596f
Made explicit
SRGDamia1 2d53ac0
Shorten interval logic
SRGDamia1 780f09b
Move include
SRGDamia1 bc28302
Fix debugging
SRGDamia1 a55c5bb
Clarify some comments
SRGDamia1 a38d2bb
Rename initial/remaining short intervals and transmissions to startup…
SRGDamia1 ae65f24
Fix useHeater logic
SRGDamia1 2db8f0a
Fix deprecated shim
SRGDamia1 96773dc
Fix the punctuation of i.e., in a *lot* of places
SRGDamia1 1044ddf
Format, switch to define
SRGDamia1 af7cecc
Fix missing docs and missing wire include
SRGDamia1 cf4a6c0
Removed all constructors for sensor-associated variables without the …
SRGDamia1 c0d303d
Removed empty variable constructor and all un-necessary "begin" varia…
SRGDamia1 779d9fd
Reordered delegating constructors
SRGDamia1 224eab2
Grammar and spacing changes
SRGDamia1 a7a5bf1
Ensure response has 12 characters
SRGDamia1 2f51824
Minor grammar, comments
SRGDamia1 a55b532
Lots of markdown formatting and grammar errors
SRGDamia1 ced9e92
Add missing begin
SRGDamia1 fd65973
More catches in markdown
SRGDamia1 2fdc98d
Forward declare wire and move include to cpp where possible
SRGDamia1 c867ffa
Rename analog objects from "base" to "reader"
SRGDamia1 3553a24
Split the clearValues function
SRGDamia1 3add2a6
Fix Atlas wire includes
SRGDamia1 5dd9074
Create helper function initializeMeasurementResult to start all addSi…
SRGDamia1 c78dd39
Update instructions
SRGDamia1 bb18d13
Remove the out-of-date library dependencies page
SRGDamia1 4621374
Revert "Forward declare wire and move include to cpp where possible"
SRGDamia1 8640b73
Moved more processor specifics into KnownProcessors and use config as…
SRGDamia1 a209266
Reran clang format
SRGDamia1 45b4178
Fix doxygen errors
SRGDamia1 44f7a24
Remove processors with multiple possible voltages or unverified values
SRGDamia1 1c2606c
F strings
SRGDamia1 4b1dc07
Remove redundant check
SRGDamia1 5edb26e
Fix guard path
SRGDamia1 c1bda7f
Restore older functionality of clearValues
SRGDamia1 747c649
Clear count value regardless of read success (original functionality)
SRGDamia1 9bc4bbf
doc changes
SRGDamia1 e82c71a
Missed renames
SRGDamia1 6d81ae8
Some minor changes
SRGDamia1 6b9e424
Reduce magic numbers, add some docs
SRGDamia1 e7153d3
Added min/max range values for variables where I knew it. Not yet used.
SRGDamia1 0356f5e
Overwrite instead of append file
SRGDamia1 ba2a27a
Comment and static assertion
SRGDamia1 83f5972
Remove static casts
SRGDamia1 1bb6fb6
Bump DHT library version
SRGDamia1 1b8fdc4
Bump DHT sensor library
SRGDamia1 79165f6
Use deep instead of deep+
SRGDamia1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json | ||
| early_access: false | ||
| enable_free_tier: true | ||
| language: en | ||
| tone_instructions: '' | ||
| knowledge_base: | ||
| learnings: | ||
| scope: auto | ||
| issues: | ||
| scope: auto | ||
| jira: | ||
| project_keys: [] | ||
| linear: | ||
| team_keys: [] | ||
| chat: | ||
| auto_reply: true | ||
| reviews: | ||
| profile: chill | ||
| request_changes_workflow: false | ||
| high_level_summary: true | ||
| high_level_summary_placeholder: '@coderabbitai summary' | ||
| poem: false | ||
| review_status: true | ||
| collapse_walkthrough: true | ||
| path_filters: | ||
| - '!**/dependencies.json' | ||
| - '!**/cspell.json' | ||
| - '!**/platformio.ini' | ||
| path_instructions: | ||
| - path: '**/*.h' | ||
| instructions: >- | ||
| Review the C++ code, point out issues relative to principles of clean | ||
| code, expressiveness, and performance. | ||
| - path: '**/*.cpp' | ||
| instructions: >- | ||
| Review the C++ code, point out issues relative to principles of clean | ||
| code, expressiveness, and performance. | ||
| tools: | ||
| shellcheck: | ||
| enabled: true | ||
| ruff: | ||
| enabled: true | ||
| markdownlint: | ||
| enabled: true | ||
| github-checks: | ||
| enabled: true | ||
| timeout_ms: 90000 | ||
| languagetool: | ||
| enabled: true | ||
| disabled_rules: | ||
| - EN_UNPAIRED_BRACKETS | ||
| disabled_categories: | ||
| - TYPOS | ||
| - TYPOGRAPHY | ||
| - CASING | ||
| enabled_only: false | ||
| level: default | ||
| biome: | ||
| enabled: true | ||
| hadolint: | ||
| enabled: true | ||
| auto_review: | ||
| enabled: true | ||
| ignore_title_keywords: | ||
| - WIP | ||
| labels: [] | ||
| drafts: true | ||
| base_branches: | ||
| - master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.