[bazel] Fully replace gentbl with gentbl_cc_library #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI appears to be failing due to llvm/llvm-project@29441e4 now. Likely needs an update in Enzyme code, although I'm not familiar w/ that change, so I don't have a fix to suggest. I was able to test this locally by pinning LLVM to an older revision. If someone can land a change to fix Enzyme w/ LLVM from trunk, I can push another empty commit to rerun CI. |
|
nocapture fix landed |
Enzyme uses tablegen generators from both llvm/tblgen.bzl and mlir/tblgen.bzl. This consolidates usage so that we only use one of them (from MLIR). Later we may delete the llvm/tblgen.bzl entirely. This is mostly mechanical, but as a side effect, we need to adjust `includes` to pick up `bundled_includes.h`. It was probably relying on an `includes` config from the llvm/tblgen.bzl implementation that is no longer being provided. See also llvm/llvm-project#124996.
…em) and use strip_include_prefix to mirror how they're referenced. Avoids needing to use `includes = ["."]` which is overly broad, and leads to a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enzyme uses tablegen generators from both llvm/tblgen.bzl and mlir/tblgen.bzl.
This consolidates usage so that we only use one of them (from MLIR).
Later we may delete the llvm/tblgen.bzl entirely.
This is mostly mechanical, but as a side effect, we need to adjust
includesto pick up
bundled_includes.h. It was probably relying on anincludesconfig from the llvm/tblgen.bzl implementation that is no longer being provided.
See also llvm/llvm-project#124996.