Skip to content

Fix broadcastosize of general abstract array #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix broadcastosize of general abstract array #1230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TracedUtils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ function elem_apply(f, args::Vararg{Any,Nargs}) where {Nargs}
return traced2_result
end

function broadcast_to_size(arg::AnyTracedRArray, rsize)
function broadcast_to_size(arg::AbstractArray{<:TracedRNumber}, rsize)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AnyTracedRArray is an alias for this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh darn, then clearly this is not a quick fix for #1229

if Reactant.isa_traced_soa(Reactant.ancestor(arg))
return broadcast_to_size(materialize_traced_array(arg), rsize)
end
Expand Down
Loading