[FIX] Remove hash generation for malformed plists - #4978
Merged
Conversation
For historical reasons if a plist does not have bug hashes we used to generate them on the fly. We also opened the plist for writing which breaks storing from Bazel where these files are readonly. Since we no longer accept non compliant plists it makes no sense to preserve this functionality. This also fixes the permission issue in Bazel.
Szelethus
added
bugfix 🔨
report-converter 🔄
bazel 🧩
Add new logic for handling 0 Hashes. Add test for new logic using old plist (renamed). Add new testfile not containing 0 Hash and update old test to use the new file. Fix unused dependancy.
Szelethus
requested changes
Jul 24, 2026
Szelethus
left a comment
Szelethus
left a comment
Contributor
There was a problem hiding this comment.
The patch is great overall, some nitpicking.
Szelethus
added
the
WARN ⚠️: Backward compatibility breaker!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For historical reasons if a plist does not have bug hashes we used to generate them on the fly. We also opened the plist for writing which breaks storing from Bazel where these files are readonly.
Since we no longer accept non compliant plists it makes no sense to preserve this functionality. This also fixes the permission issue in Bazel.