This repository was archived by the owner on Feb 5, 2025. It is now read-only.
feat: added tests for transaction details #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests to prevent regression of DESC ordering: - Refering to the previously fixed issue where DESC + OFFSET incorrectly skipped recent transactions - Fixed query syntax compatibility between SQLite and PostgreSQL for LIMIT/OFFSET ordering - `src/data_source/storage/sql/queries/explorer.rs` - The written test in it - Introduced syntax compatibility between SQLite and PostgreSQL - Transaction ordering test to prevent DESC regression: ``` cargo nextest run test_transaction_detail_asc_ordering ``` - Verified with both `--all-features` and individual feature flags - Added conditional query formatting based on database backend - Introduced test for ordering stays ASC to prevent re-introduction of DESC + OFFSET bug that caused incorrect transaction skipping Previous Error (introduced test prior queury compatibilty): ``` near OFFSET: syntax error ``` * wip: verification for transaction ASC ordering to prevent offset regression * fix: addressed OFFSET clause ordering in transaction query * fix: handle SQLite vs PostgreSQL LIMIT/OFFSET * refact: cargo fmt && cargo clippy
0xObsidian
requested review from
sveitser,
jbearer and
imabdulbasit
as code owners
|
Hi @imabdulbasit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Key places to review:
src/data_source/storage/sql/queries/explorer.rsThings tested
--all-featuresand individual feature flagsImplementation Details
Previous Error ( in the introduced test prior additionally addressing query compatibility ):