Skip to content

Update router_config.dart #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update router_config.dart #371

wants to merge 2 commits into from

Conversation

harish-kunchala
Copy link
Collaborator

Unify Sample Routing and Restore Single-Sample Runner

  • Replace separate routes for downloadable-resources and live-view in router_config.dart with a single /sample/:sample route and redirect logic based on downloadableResources.isNotEmpty.
  • Verified navigation in the full Sample Viewer: selecting samples with and without downloads routes correctly and back navigation returns to categories.

@PaulAllanSturm
Copy link
Collaborator

The SampleInfoPopupMenu doesn't seem to work any more -- I can't get to the "README" or "Code" pages. Probably because of the special logic in _navigateTo() that examines the GoRouter stack.

@PaulAllanSturm
Copy link
Collaborator

This PR is now showing no changes

@harish-kunchala
Copy link
Collaborator Author

Opened another router config PR which simplifies router config. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulAllanSturm PaulAllanSturm Awaiting requested review from PaulAllanSturm

@changanxian changanxian Awaiting requested review from changanxian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harish-kunchala @PaulAllanSturm