Skip to content

Conversation

kaushikrw
Copy link
Collaborator

@kaushikrw kaushikrw commented Sep 27, 2025

Related to issue: #apollo/1236

Description:

This PR adds the implementation for adding UN associations through the toolkit.

Summary of changes:

  • Encapsulated navigation code into extension methods based on the android guide.
  • Introduced a nested navigation graph for the add association workflow.
  • Introduced a ViewModel scoped to this nested graph to handle the data and operations.
  • Introduced various screens for the Add Association Workflow.
  • All the UI implements the figma design specified here.

Test data

Test data is in the linked issue.

Pre-merge Checklist

@kaushikrw kaushikrw marked this pull request as ready for review October 3, 2025 17:34
@kaushikrw kaushikrw self-assigned this Oct 3, 2025
@kaushikrw kaushikrw requested a review from puneet-pdx October 3, 2025 18:49
Copy link
Collaborator

@puneet-pdx puneet-pdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikrw looks good overall. Few questions/comments

Copy link
Collaborator

@puneet-pdx puneet-pdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more rename suggestion

@kaushikrw kaushikrw requested a review from puneet-pdx October 7, 2025 17:48
Copy link
Collaborator

@puneet-pdx puneet-pdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikrw Looks good 👍🏽

Copy link
Collaborator

@puneet-pdx puneet-pdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikrw just a minor comment.

@kaushikrw
Copy link
Collaborator Author

Thanks @puneet-pdx, merging.

@kaushikrw kaushikrw merged commit 79bf63d into feature-branches/forms Oct 7, 2025
@kaushikrw kaushikrw deleted the kaushik/forms/una-add-feature-1 branch October 7, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants