-
Notifications
You must be signed in to change notification settings - Fork 8
FeatureForm
: UNA Add Implementation (Feature 1)
#988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeatureForm
: UNA Add Implementation (Feature 1)
#988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaushikrw looks good overall. Few questions/comments
...arcgismaps/toolkit/featureforms/internal/components/utilitynetwork/UtilityTerminalControl.kt
Outdated
Show resolved
Hide resolved
...toolkit/featureforms/internal/components/utilitynetwork/AddAssociationFromSourceViewModel.kt
Show resolved
Hide resolved
...gismaps/toolkit/featureforms/internal/components/utilitynetwork/UtilityAssociationDetails.kt
Show resolved
Hide resolved
...gismaps/toolkit/featureforms/internal/components/utilitynetwork/UtilityAssociationDetails.kt
Outdated
Show resolved
Hide resolved
...gismaps/toolkit/featureforms/internal/components/utilitynetwork/UtilityAssociationDetails.kt
Outdated
Show resolved
Hide resolved
...main/java/com/arcgismaps/toolkit/featureforms/internal/navigation/AddFromSourceNavigation.kt
Show resolved
Hide resolved
...main/java/com/arcgismaps/toolkit/featureforms/internal/navigation/AddFromSourceNavigation.kt
Outdated
Show resolved
Hide resolved
...main/java/com/arcgismaps/toolkit/featureforms/internal/navigation/AddFromSourceNavigation.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/arcgismaps/toolkit/featureforms/internal/navigation/FeatureFormNavHost.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/arcgismaps/toolkit/featureforms/internal/navigation/FeatureFormNavigation.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more rename suggestion
...toolkit/featureforms/internal/components/utilitynetwork/AddAssociationFromSourceViewModel.kt
Outdated
Show resolved
Hide resolved
...toolkit/featureforms/internal/components/utilitynetwork/AddAssociationFromSourceViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaushikrw Looks good 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaushikrw just a minor comment.
...main/java/com/arcgismaps/toolkit/featureforms/internal/navigation/AddFromSourceNavigation.kt
Outdated
Show resolved
Hide resolved
Thanks @puneet-pdx, merging. |
Related to issue: #apollo/1236
Description:
This PR adds the implementation for adding UN associations through the toolkit.
Summary of changes:
Test data
Test data is in the linked issue.
Pre-merge Checklist