-
Notifications
You must be signed in to change notification settings - Fork 15
FeatureFormView
- Use List
#1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dfeinzimer
wants to merge
57
commits into
v.next
Choose a base branch
from
df/FFV_As_List
base: v.next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into df/FFV_As_List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on @zkline101's work in #1034 to enhance
FeatureFormView
by converting the internalVStack
to aList
.Since #1034,
FeatureFormView
has grown in complexity to supportUtilityAssociationsFormElement
s. As part of that work,FeatureFormGroupedContentView
was needed to mimic the appearance of a section in a list.FeatureFormView
was also refactored to wrap a new internalEmbeddedFeatureFormView
with aNavigationStack
. With more form elements in the pipeline, now is a good time to revisit adopting platform provided types likeList
to streamline future enhancement work.Issues
GroupFormElement
will revert to its initial expanded/collapsed state when it's scrolled out-of and back into view.Considerations
Form
makes more sense thanList
, however I've found no practical visual difference between the two.List
also has a convenientinit(_:id:editActions:rowContent:)
that lets us avoid an innerForEach
.Form
does not provide the same.