fix: prevent sending sign paste messages if SignChangeEvent is cancelled #6136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes no existing issue.
Details
Proposed fix:
Prevent sending messages related to sign text or copied lines when the SignChangeEvent has been cancelled.
Previously, even if the event was cancelled by another plugin, messages would still be sent to the player. This change ensures that no feedback about sign changes is given if the event does not proceed, maintaining correct plugin behavior and avoiding confusion.
Environments tested:
OS: Linux Ubuntu 20.04.6 LTS (Focal Fossa)
Java version: Java 21
Demonstration:
SignChangeEvent
.