Cleanup User Preferences page + Implement #8 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement right-click by default preference (#8) Added check for updates button (simply links through to the GitHub repo) Cleaned up/reorganized some of the user preferences code, to be a little more maintainable Fixed inconsistent naming throughout the user preferences Moved dedicated `notes.md` file into the repo README
EthanSK
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @EthanSK! Thanks once again for this awesome project, I've loved having it in my daily workflow!
I spent a few hours today trying to implement solutions for a few of the open issues (namely #8, #17, #23). Unfortunately, I didn't have much luck with #17 and #23 due to there not being any official Apple APIs to support this functionality (as far as I could tell).
I was however able to implement a "Right-click by default" user preference (closes #8), and also took the time to reorganize the user preferences code to be more consistent, and more maintainable moving forward :) As I was hoping to implement several new user preferences, I spent some time reorganizing the layout of the options in the User Preferences view. As mentioned in my previous PR, I'm new to Swift and XCode, so constraints took a bit of getting used to (I mostly resorted to using XCode's "reset/add missing constraints"). I also added a "Check for Updates" button, which just opens the releases page for this repo.
Let me know what you think, and I'll happily make changes if needed! I doubt I'll have time again soon to implement further functionality, primarily as it now does exactly what I personally need it to.
Screenshot of the changes to the User Preferences view: